Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architect prunes static files before deploying CloudFormation stack #390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gimdongwoo
Copy link

@gimdongwoo gimdongwoo commented Jul 20, 2024

Thank you for helping out! ✨

We really appreciate your commitment to improving Architect

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • Forked the repo and created your branch from main
  • Made sure tests pass (run npm it from the repo root)
  • Expanded test coverage related to your changes:
    • Added and/or updated unit tests (if appropriate)
    • Added and/or updated integration tests (if appropriate)
  • Updated relevant documentation:
  • Summarized your changes in changelog.md
  • Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

Please also be sure to completed the CLA (if you haven't already).

Learn more about contributing to Architect here.

Thanks again!

Purpose

I discovered that during the arc deploy process, the CloudFormation stack was deployed before the static assets were uploaded.
A service error occurs because the static asset cannot be found.
Upon investigating the issue, I found that code changes had been made to address this in the following issue:
architect/architect#1416.
However, I do not understand why a fingerprint is required, as it works well without fingerprint check.
I don't use fingerprint option. I use Remix with architect, in which case the fingerprint option is not available.
I used the patch-package tool to modify this part, and I confirmed that my service operates as intended afterward.

Thanks!

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants