Fix events.subscribe types: returns either an async or promise function #563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning
unknown
fromevents.subscribe
, as the types do today, sucks if you're writing tests:This PR attempts to address this by tweaking the return type of
subscribe
, which is conditional based on what kind of event handler function you pass intosubscribe
:subscribe
returns an async function.With these changes, now my tests are tidier with less IDE complaints. With an async handler the result looks like:
.. and using a callback interface, too:
No matter which style of handler you pass, at least in the context of my tests, now my IDE knows that I am dealing with functions - even the right kinds to boot!