Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cpr #194

Merged
merged 8 commits into from
Aug 6, 2024
Merged

remove cpr #194

merged 8 commits into from
Aug 6, 2024

Conversation

tbeseda
Copy link
Member

@tbeseda tbeseda commented Jul 31, 2024

cpr has a couple warnings for vulnerabilities and will probably continue to decay as it's not maintained.

That said, we probably don't need it since Node 16.7+ supports the features of cpr we are using.

Most of this is:

- let cp = require('cpr')
+ let { cp } = require('fs')

-   cp(source, destination, { overwrite: true }, callback)
+   cp(source, destination, { recursive: true, force: true }, callback)

There was also some experimental tests on newer Ruby bundler - this was discarded.

@tbeseda tbeseda marked this pull request as ready for review August 5, 2024 21:27
src/actions/autoinstall/index.js Show resolved Hide resolved
@tbeseda tbeseda merged commit 00e6c18 into main Aug 6, 2024
27 checks passed
@tbeseda tbeseda deleted the tbeseda/remove-cpr branch August 6, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants