Make who_depends_this_lib much faster #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilydjwg
requested changes
Oct 25, 2019
|
Thank you for the review. I added a commit to address those comments. Here is an issue: it turns out that a few packages are built using pacman < 5.1, so that there is no valid |
|
Yes, we can rebuild those packages. Can you get a list of them? |
|
Here is the package list: pkgs.txtAnd raw output using https://github.com/yan12125/misc_scripts/commit/affb9afb52de8eb6daee7b3e98bfb00facb3307c: buildinfo-issue.txtIf all looks good, I can open an issue in archlinuxcn/repo. By the way, how to get a list of packages categorized by maintainers like archlinuxcn/repo#1073 (comment)? |
|
那个文本是用这样的 Python 脚本生成的： script issue1073#!/usr/bin/python3
from pathlib import Path
import logging
from collections import defaultdict
from lilac2 import lilacpy
logger = logging.getLogger(__name__)
def main():
repodir = Path('/ldata/src/archgitrepo/archlinuxcn')
mods, _ = lilacpy.load_all(repodir)
r = defaultdict(list)
for name, m in mods.items():
if getattr(m, 'build_prefix', '').startswith(('archlinuxcn-', 'multilib-archlinuxcn')):
for x in m.maintainers:
r[x['github']].append(name)
for who, pkgs in sorted(r.items()):
print(f'@{who}:')
for pkg in pkgs:
print('* [ ]', pkg)
print()
if __name__ == '__main__':
from nicelogger import enable_pretty_logging
enable_pretty_logging('DEBUG')
main() |
|
It looks OK, please open an issue to move things forward 👍 |
71 tasks
|
Looks like |
|
I changed |
|
Thanks! |
12 tasks
An example run: $ time env PYTHONPATH=$HOME/tmp/winterpy/pylib python who_depends_this_lib /data/repo/x86_64/archlinuxcn.files libproto protobuf >&| ~/tmp/output env PYTHONPATH=$HOME/tmp/winterpy/pylib python who_depends_this_lib libproto 72.35s user 6.32s system 99% cpu 1:19.26 total [WIP] address review comments Avoid duplicated checking Caused by /depends entries, which are from pacman <= 3.4 (!) [1] Also improves warning messages [1] https://git.archlinux.org/pacman.git/tree/scripts/pacman-db-upgrade.sh.in?h=v5.2.0#n151 Checking packages without proper .BUILDINFO anyway So that this PR can be used before archlinuxcn/repo#1351 is done.
|
Squashed and force-pushed. I consider this ready for another review if you want to merge it before archlinuxcn/repo#1351 is done and you are fine with nasty |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example run: