Use ArSvgies package + cache images in localStorage for wallets and contacts #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaswma
requested changes
Feb 23, 2024
You are right! I'm only generating the cached image for the ones being added 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the dynamic generative script with the @7i7o/arsvgies package to generate fallback avatars for wallets and contacts
This package includes an update to generate colors from a hash to clearly distinguish wallets that create a similar shape
It also stores the generated images in localStorage for wallets and contacts to avoid processing the generative art everytime a contact or wallet component in mounted in the UI
The PR unifies all the images shapes for wallets into squircles, removing the rounded images that were used in some places for contacts