Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds delete and get subscription route #425

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

nicholaswma
Copy link
Contributor

No description provided.

@nicholaswma nicholaswma requested a review from 7i7o July 9, 2024 02:49
Copy link
Contributor

@7i7o 7i7o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 👍

Usage issues:

  • devs can read all subscriptions if they have the permissions
  • deleteSubscription actually removes the subscription instead of canceling from the list of subscriptions (user can no longer see their past payments or previous subscription)
  • deleteSubscription doesn't show popup neither needs any user confirmation
  • devs can delete any subscription (without user confirmation) if they know the targetId

Previous subscription rough edges:

  • If user cancels a subscription, they can no longer subscribe to the same address: Console shows Account is already subscribed. Users need to remove subscription (loosing all subscription payments history) to be able re-subscribe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants