Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic: Embedded Wallet PoC #497

Draft
wants to merge 5 commits into
base: development
Choose a base branch
from
Draft

Conversation

Danziger
Copy link
Contributor

@Danziger Danziger commented Oct 15, 2024

  • Alias/polyfill browser.i18n API.
  • Alias/polyfill all other browser.* calls (with lazy-loading per view?).
  • Create new build setup with Vite for the embedded version.
  • Replace links to “dashboard” with the "quick settings" version within the same iframe. Check if we have feature parity.
    See Update most links to dashboard to open in quick-settings instead. #500
  • Update router to be config-driven and lazy-load routes.
  • Add a hidden “launcher” to navigate to specific views (for development).
  • Replace /src/injected.ts and /src/api/index.ts with something similar to Othent. There, the “api” module should actually be a strategy, so that we can have a different one for the embedded wallet that sends “requests” to the iframe using postMessage().
  • popup.tsx (main file) needs to listen for postMessage() coming from the new injected API (similar to the Express server in Othent). Consider adding something similar to the JWTs in Othent so that only the actual app (and not some XSS snippet or malicious extension) can contact it.

Notes for additional changes:

  • Find all usages of getDecryptionKey. Those have to be replaced with something else in the embedded wallet.
  • There's no "disconnect" in the embedded wallet.

@Danziger Danziger marked this pull request as draft October 15, 2024 15:24
@Danziger Danziger changed the base branch from production to development October 15, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant