Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve token & contact routes black screen #535

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

pawanpaudel93
Copy link
Contributor

Summary

This PR fixes the Import Token black screen issue.

@pawanpaudel93
Copy link
Contributor Author

@7i7o @nicholaswma This seems to be the issue of matching both paths /quick-settings/tokens/new and /quick-settings/tokens/:id for Import Token (/quick-settings/tokens/new) and rendering both routes on top of each other.

Possible solutions:

  1. As the PR
  2. Rename the conflicting routes path so it only matches a single route for a path.

wdyt ?

@nicholaswma
Copy link
Contributor

@pawanpaudel93 if possible I think renaming the path would be the better course so we don't encourage this type of pattern, but I'm okay with this solution for the time being

@pawanpaudel93 pawanpaudel93 changed the title fix: check route content to resolve black screen fix: resolve token & contact routes black screen Nov 6, 2024
@pawanpaudel93
Copy link
Contributor Author

@nicholaswma I used Switch now for those overlapping routes so only the first match is returned.

Copy link
Contributor

@nicholaswma nicholaswma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK - works great! 🚀

Copy link
Contributor

@7i7o 7i7o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 👍

Also agree with Nick that we should use non-overlapping routes in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants