Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new example Random Rotate #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

KAbhijeet2105
Copy link

Added new simple example Random Rotate. It will help to understand working of servo motor and servo library functions.
random_rotate

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run a Tools > Auto Format in the Arduino IDE on your sketch to ensure consistent formatting.

examples/Random_Rotate/Random_Rotate/Random_Rotate.ino Outdated Show resolved Hide resolved
examples/Random_Rotate/Random_Rotate/Random_Rotate.ino Outdated Show resolved Hide resolved
@KAbhijeet2105
Copy link
Author

@per1234 I have done the requested changes please let me know if there is anything else,
Thank you

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have an unnecessary extra folder level:

Servo
|_examples
   |_Random_Rotate
      |_Random_Rotate
         |_Random_Rotate.ino

It should be:

Servo
|_examples
   |_Random_Rotate
      |_Random_Rotate.ino

To be consistent with the file name convention used in official Arduino sketches The sketch should be named RandomRotate, not Random_Rotate.

examples/Random_Rotate/Random_Rotate/Random_Rotate.ino Outdated Show resolved Hide resolved
examples/Random_Rotate/Random_Rotate/Random_Rotate.ino Outdated Show resolved Hide resolved
@per1234 per1234 dismissed their stale review March 19, 2020 09:46

Requested changes have been made. Thanks!

examples/PushRotate/PushRotate.ino Outdated Show resolved Hide resolved
examples/PushRotate/PushRotate.ino Outdated Show resolved Hide resolved
examples/PushRotate/PushRotate.ino Outdated Show resolved Hide resolved
@per1234
Copy link
Contributor

per1234 commented Mar 26, 2020

The fritzing is unnecessarily huge, both in file size (252 KB), as well as the amount of unnecessary space taken up by huge spacing between wires.

@KAbhijeet2105
Copy link
Author

The fritzing is unnecessarily huge, both in file size (252 KB), as well as the amount of unnecessary space taken up by huge spacing between wires.

Thanks for your feedback. But, should I change the diagram or remove it?

@KAbhijeet2105
Copy link
Author

@per1234 I have done the requested changes please let me know if there is anything else,
Thank you

@per1234 per1234 removed their request for review March 10, 2021 00:02
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added type: enhancement Proposed improvement topic: documentation Related to documentation for the project labels Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants