Make library compatible with NINA WiFi module #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should change library name too :)
per1234
requested changes
Aug 9, 2019
per1234
reviewed
Aug 9, 2019
|
For MKR Vidor 4000, should we document somewhere (maybe the read me) that sketches that contain bitstreams can't be used? |
The readme looks a good place for this info 👍 |
|
I would prefer it to be documented in the library reference page. I think that will make the information more visible to the users: |
per1234
requested changes
Aug 25, 2019
| @@ -0,0 +1,91 @@ | |||
| /* | |||
|
|
|||
| This example connects to an WPA encrypted WiFi network. | |||
There was a problem hiding this comment.
Suggested change
| This example connects to an WPA encrypted WiFi network. | |
| This example connects to a WPA encrypted WiFi network. |
| /* | ||
|
|
||
| This example connects to an WPA encrypted WiFi network. | ||
| Then it prints the MAC address of the Wifi shield, |
There was a problem hiding this comment.
Suggested change
| Then it prints the MAC address of the Wifi shield, | |
| Then it prints the MAC address of the WiFi shield, |
|
|
||
| // print the received signal strength: | ||
| long rssi = WiFi.RSSI(); | ||
| Serial.print("signal strength (RSSI):"); |
There was a problem hiding this comment.
Suggested change
| Serial.print("signal strength (RSSI):"); | |
| Serial.print("signal strength (RSSI): "); |
n-gineer
suggested changes
Jun 26, 2020
| name=WiFi101OTA | ||
| version=1.0.2 | ||
| name=Arduino_WiFiOTA | ||
| version=1.1.0 | ||
| author=Arduino | ||
| maintainer=Arduino <[email protected]> | ||
| sentence=Update sketches on your board over WiFi | ||
| paragraph=Requires an Arduino/Genuino SAMD board |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on arduino/nina-fw#32 and arduino-libraries/WiFiNINA#74