Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MrOctopus/download-asset-action from 1.0 to 1.1 #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 19, 2023

Bumps MrOctopus/download-asset-action from 1.0 to 1.1.

Release notes

Sourced from MrOctopus/download-asset-action's releases.

1.1

Updated dependencies and changed running environment to node16

Full Changelog: MrOctopus/download-asset-action@1.0...1.1

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [MrOctopus/download-asset-action](https://github.com/mroctopus/download-asset-action) from 1.0 to 1.1.
- [Release notes](https://github.com/mroctopus/download-asset-action/releases)
- [Commits](MrOctopus/download-asset-action@1.0...1.1)

---
updated-dependencies:
- dependency-name: MrOctopus/download-asset-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the topic: infrastructure Related to project infrastructure label Sep 19, 2023
@per1234 per1234 self-assigned this Dec 7, 2023
@per1234 per1234 added type: enhancement Proposed improvement status: on hold Do not proceed at this time labels Dec 7, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with the MrOctopus/download-asset-action action (MrOctopus/download-asset-action#8) that caused the CI failures at the time the PR was submitted has been fixed (MrOctopus/download-asset-action@d66a497), but the fact that a fundamentally broken release was made in the first place (indicating there is no validation/quality control of the action whatsoever), and then the way the fix was deployed (by moving the existing 1.1 tag instead of making a new tag) tells me that we should try to migrate away from using MrOctopus/download-asset-action if possible.

An approach for installing ClangFormat going forward will also need to be decided upon in arduino/tooling-project-assets#395.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: on hold Do not proceed at this time topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant