fix: platform release version ordering

Signed-off-by: Akos Kitta <[email protected]>
arduino · Jan 18, 2024 · 6f5feb3 · 6f5feb3
1 parent d5b0a4d
commit 6f5feb3
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/arduino-ide-extension/src/node/boards-service-impl.ts b/arduino-ide-extension/src/node/boards-service-impl.ts
@@ -589,6 +589,9 @@ function createBoardsPackage(
     return undefined; // never show incompatible platforms
   }
   const { id, website, maintainer } = summary.metadata;
+  const availableVersions = Array.from(versionReleaseMap.keys())
+    .sort(Installable.Version.COMPARATOR)
+    .reverse();
   return {
     id,
     name,
@@ -602,7 +605,7 @@ function createBoardsPackage(
     moreInfoLink: website,
     author: maintainer,
     deprecated,
-    availableVersions: Array.from(versionReleaseMap.keys()),
+    availableVersions,
   };
 }
 

diff --git a/arduino-ide-extension/src/test/node/boards-service-impl.slow-test.ts b/arduino-ide-extension/src/test/node/boards-service-impl.slow-test.ts
@@ -1,7 +1,7 @@
 import { DisposableCollection } from '@theia/core/lib/common/disposable';
 import { Container } from '@theia/core/shared/inversify';
 import { expect } from 'chai';
-import { BoardSearch, BoardsService } from '../../common/protocol';
+import { BoardSearch, BoardsService, Installable } from '../../common/protocol';
 import { createBaseContainer, startDaemon } from './node-test-bindings';
 
 describe('boards-service-impl', () => {
@@ -24,6 +24,29 @@ describe('boards-service-impl', () => {
       expect(result).is.not.empty;
     });
 
+    it('should order the available platform release versions in descending order', async function () {
+      const result = await boardService.search({});
+      result.forEach((platform) =>
+        platform.availableVersions.forEach(
+          (currentVersion, index, versions) => {
+            if (index < versions.length - 2) {
+              const nextArrayElement = versions[index + 1];
+              const actual = Installable.Version.COMPARATOR(
+                currentVersion,
+                nextArrayElement
+              );
+              expect(actual).to.be.greaterThan(
+                0,
+                `Expected '${currentVersion}' to be gt '${nextArrayElement}'. All versions: ${JSON.stringify(
+                  versions
+                )}`
+              );
+            }
+          }
+        )
+      );
+    });
+
     it("should boost a result when 'types' includes 'arduino', and lower the score if deprecated", async () => {
       const result = await boardService.search({});
       const arduinoIndexes: number[] = [];