fix: upload waits for monitor connection to close #2192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 24, 2023 16:55
Signed-off-by: Akos Kitta <[email protected]>
Closes #1783 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
added
topic: code
|
Will be part of #2334. I am closing as a duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
IDE2 must wait for the monitor connection to close before an upload can start gracefully. With the new CLI APIs, it's possible to request a close from the client and wait for the server (CLI) to free up the resources (ports), then iDE2 can start the upload.
Change description
grpc_tools_node_protoc_tsto the latest. It's the lib to do theprototojs/tsgeneration.Other information
Closes #1783
Reviewer checklist