Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy example with .pde main sketch file #2381

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix: copy example with .pde main sketch file #2381

merged 1 commit into from
Feb 22, 2024

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Feb 22, 2024 •
edited
Loading

Motivation

Fix the examples opening with the .pde main sketch file extension.

2377-fix.mp4

Change description

Do not assume the .ino extension for the main sketch file when copying a sketch.

Other information

Closes #2377

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 22, 2024
@kittaakos kittaakos merged commit aa9b10d into main Feb 22, 2024
25 checks passed
@kittaakos kittaakos deleted the #2377 branch February 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giacomocusinato giacomocusinato giacomocusinato approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening example with .pde file extension fails silently
2 participants
@kittaakos @giacomocusinato