Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose search engine ping max time as a new environment variable #4997

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Jun 11, 2024

Description

This PR will expose a new ARGILLA_SEARCH_ENGINE_PING_TIMEOUT environment variable allowing us to control the maximum time (in seconds) waiting for the search engine to be ready when starting up Argilla server.

The default value for this environment variable is still 60 seconds as before. I will modify our Argilla template on Hugging Face to set this to a higher value (120 for example).

This change is motivated by @davidberenstein1957 and @dvsrepo reporting errors on Hugging Face Spaces related with Argilla not starting up after waiting for Elasticsearch.

Task to do after merging this PR:

  • Merge PR on Argilla template at HF Spaces setting a value of 120 seconds for this new environment variable: link to PR.

Refs #4946

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Manually testing the new environment variable locally.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon June 11, 2024 15:36
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (a667a90) to head (634448d).

Additional details and impacted files
@@             Coverage Diff              @@
##           feat/v2.0.0    #4997   +/-   ##
============================================
  Coverage        91.98%   91.99%           
============================================
  Files              135      135           
  Lines             5804     5806    +2     
============================================
+ Hits              5339     5341    +2     
  Misses             465      465           
Flag Coverage Δ
argilla-server 91.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from chore/set-logger-level-to-error-for-search-engine to feat/v2.0.0 June 12, 2024 14:12
Base automatically changed from feat/v2.0.0 to develop June 19, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant