Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add some SQLite pragma statement settings to improve performance #5192

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Jul 9, 2024

After suffering general slowness in HF spaces after merging the SQLite fine tuning changes I have reverted the changes so we can focus on distribution task changes.

After that we will investigate if these changes are the source of the slowness with HF Spaces using persistent storage or not.

Reverts #5191

@jfcalvo jfcalvo requested a review from frascuchon July 9, 2024 14:27
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.11%. Comparing base (31b3c6a) to head (eb4c94a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5192      +/-   ##
===========================================
+ Coverage    91.08%   91.11%   +0.02%     
===========================================
  Files          150      150              
  Lines         6250     6255       +5     
===========================================
+ Hits          5693     5699       +6     
+ Misses         557      556       -1     
Flag Coverage Δ
argilla-server 91.11% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon added this to the v2.1.0 milestone Jul 19, 2024
@frascuchon frascuchon modified the milestones: v2.1.0, v2.2.0 Sep 3, 2024
@frascuchon
Copy link
Member

We should check these improvements in HF Spaces removing all the WAL-related ones.

@jfcalvo jfcalvo modified the milestones: v2.2.0, v2.3.0 Sep 18, 2024
@frascuchon frascuchon removed this from the v2.3.0 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants