Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keycloak SSO #5711

Open
wants to merge 7 commits into
base: refactor/argilla-server/better-oauth2-integration
Choose a base branch
from

Conversation

paulbauriegel
Copy link
Contributor

Add keycloak SSO

Based on discussion in #5691

Points that need some feedback:

  • A lot of configurations are set via env variables now. Not sure if that's ideal, error messages if something is not set correctly can be rather cryptic with social auth lib
  • I added the Keycloak logo to the Oauth button id the provider is keycloak, generally the same could also be done for the HF logo not having a separate button
  • Is the documentation to set-up a keycloak server sufficient?

Type of change

  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested
Local build & Keycloak installation as described in the documentation.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • TODO I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@davidberenstein1957
Copy link
Member

Related #5691

@paulbauriegel
Copy link
Contributor Author

I tested it a bit with a local set-up but it does not seem to work. I need some time to debug it, to understand why it is not working.

@frascuchon frascuchon force-pushed the feature/better-oauth2-integration-keycloak branch from cc5ca0c to bf2a0f6 Compare December 5, 2024 11:34
@frascuchon
Copy link
Member

I tested it a bit with a local set-up but it does not seem to work. I need some time to debug it, to understand why it is not working.

I've pushed some missing tests to see the expected values https://github.com/argilla-io/argilla/blob/bf2a0f64a991731602cd521188dd95bb3896d7ea/argilla-server/tests/unit/api/handlers/v1/test_oauth2.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants