Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing tests argilla labeller #1017

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

davidberenstein1957
Copy link
Member

@davidberenstein1957 davidberenstein1957 commented Oct 7, 2024

I moved the validation to the process method, causing the tests to fail. I think it is good to also test it during the format_input and add the tests there.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@davidberenstein1957 davidberenstein1957 changed the base branch from main to develop October 7, 2024 08:29
@davidberenstein1957 davidberenstein1957 marked this pull request as ready for review October 7, 2024 08:29
Copy link

github-actions bot commented Oct 7, 2024

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-1017/

Copy link

codspeed-hq bot commented Oct 7, 2024

CodSpeed Performance Report

Merging #1017 will not alter performance

Comparing fix/failing-tests-argilla-labeller (3808aa6) with develop (4848dd2)

Summary

✅ 1 untouched benchmarks

@gabrielmbmb gabrielmbmb merged commit d5c0484 into develop Oct 7, 2024
7 checks passed
@gabrielmbmb gabrielmbmb deleted the fix/failing-tests-argilla-labeller branch October 7, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants