Move all LLMs to distilabel.models #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1045 will not alter performanceComparing Summary
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-1045/ |
gabrielmbmb
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
LGTM! In order to not break anything, we should allow importing from distilabel.llms and distilabel.embeddings at least for a few releases. Let's create a src/distilabel/llms.py and src/distilabel/embeddings.py re-importing classes from distilabel.models.llms and distilabel.models.embeddings respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor of
distilabel.llmsanddistilabel.embeddingstodistialbel.models, where all modelling related functionalities will live now, to accomodate future different models, say vision llms. Alsodistilabel.llms.mixinsare now atdistilabel.models.mixins.Closes #1040