Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new response_format variable in openai api #1053

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

plaguss
Copy link
Contributor

@plaguss plaguss commented Nov 7, 2024

Description

OpenAI has a new expected value for JSON mode, but we couldn't reach for it using the generate method (https://platform.openai.com/docs/guides/structured-outputs#json-mode). This PR fixes it.

Closes #1048

@plaguss plaguss added the fix label Nov 7, 2024
@plaguss plaguss added this to the 1.5.0 milestone Nov 7, 2024
@plaguss plaguss self-assigned this Nov 7, 2024
@plaguss plaguss linked an issue Nov 7, 2024 that may be closed by this pull request
@plaguss plaguss mentioned this pull request Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-1053/

Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #1053 will not alter performance

Comparing fix-openai-response-format (ae061bc) with develop (f949640)

Summary

✅ 1 untouched benchmarks

@plaguss plaguss merged commit 53e46c1 into develop Nov 7, 2024
8 checks passed
@plaguss plaguss deleted the fix-openai-response-format branch November 7, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OepnAI JSON format
1 participant