-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Include new GeneratorStep
classes to load datasets from different formats
#691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaguss
requested review from
alvarobartt and
gabrielmbmb
and removed request for
alvarobartt
June 3, 2024 14:02
plaguss
changed the title
Dataloaders
[FEATURE] Include new Jun 4, 2024
GeneratorStep
classes to load datasets from different formats
alvarobartt
reviewed
Jun 4, 2024
alvarobartt
reviewed
Jun 4, 2024
gabrielmbmb
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The only thing I'm missing is updating how we get the dataset info.
…posed function from datasets
CodSpeed Performance ReportMerging #691 will not alter performanceComparing Summary
|
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a new
GeneratorStep
to load data from files in disk, and renames the generator classes for consistency.Step renames:
The old ones will throw a
DeprecationWarning
to be removed in1.3.0
.Two new classes
LoadFromFileSystem
:The idea for this new
Step
is to allow reading data from files in disk, like what you would have withload_dataset
:The file extension (the initial
csv
) will be inferred internally if possible. It works with files in remote filesystems (s3, gcs, etc).To read remote files, for gcs for example (assuming the credentials are already stored):
LoadFromDisk
:This is the way to read
Distiset
s saved in disk