Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather HF_TOKEN internally when calling Distiset.push_to_hub if token is None. #707

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

plaguss
Copy link
Contributor

@plaguss plaguss commented Jun 10, 2024

Description

We will try to load the HF_TOKEN internally if possible, or raise a ValueError if not possible, to avoid propagating the error.

Closes #693

…push_to_hub and mode constant value to distilabel.utils module
@plaguss plaguss added this to the 1.2.0 milestone Jun 10, 2024
@plaguss plaguss self-assigned this Jun 10, 2024
Copy link

codspeed-hq bot commented Jun 10, 2024

CodSpeed Performance Report

Merging #707 will not alter performance

Comparing distiset-hf-token (2b552bc) with develop (1d53ee8)

Summary

✅ 1 untouched benchmarks

src/distilabel/distiset.py Outdated Show resolved Hide resolved
src/distilabel/distiset.py Outdated Show resolved Hide resolved
@plaguss plaguss requested a review from gabrielmbmb June 11, 2024 10:34
@gabrielmbmb gabrielmbmb merged commit a0d7e93 into develop Jun 11, 2024
7 checks passed
@gabrielmbmb gabrielmbmb deleted the distiset-hf-token branch June 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add functionality to read/pass HF_TOKEN from cache/env var.
2 participants