-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StepResources
and step replicas in Pipeline
#750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #750 will degrade performances by 13.44%Comparing Summary
Benchmarks breakdown
|
`routing_batch_function`
plaguss
approved these changes
Jun 27, 2024
docs/sections/how_to_guides/advanced/assigning_resources_to_step.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Agus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
StepResource
class that allow defining the resources and replicas required for eachStep
. It also adds aresources
attribute to theStep
class, and updates the_run_steps
methods to create the number of replicas specified. In addition, the_BatchManager
has been updated to handle receiving unsorted batches by itsseq_no
due to theStep
replicas.