-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Magpie
and MagpieGenerator
tasks
#778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`InferenceEndpointsLLM`
Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-778/ |
CodSpeed Performance ReportMerging #778 will not alter performanceComparing Summary
|
plaguss
reviewed
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! will review again once it's ready for review 👍
Closed
plaguss
approved these changes
Jul 12, 2024
plaguss
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two new tasks
Magpie
andMagpieGenerator
based on Magpie: Alignment Data Synthesis from Scratch by Prompting Aligned LLMs with Nothing paper, which presents a new way to leverage chat template and the autoregressive capabilities of the instruct fine-tuned LLMs to generate instructions without seed data or a specific system prompt.In addition, a new mixin
MagpieChatTemplateMixin
has been added that has to be used in combination with the aforementioned tasks. This mixin requiresLLM
s that are able to send the raw input (with special tokens, etc) to the LLM, so at this moment only theTransformersLLM
,vLLM
andInferenceEndpointsLLM
uses the mixin and therefore are the only LLMs that can be used with the new tasks.Finally,⚠️ Even though with the new
InferenceEndpointsLLM
has been updated and theuse_openai_client
argument has been removed (and the use of the OpenAI client) as it was not used and didn't add any additional functionality that thehuggingface_hub.AsyncInferenceClient
doesn't offer. In addition, iftokenizer_id
is not provided, then thechat_completion
method from thehuggingface_hub.AsyncInferenceClient
is used instead of thetext_generation
.chat_generation
methods a list oftools
can be passed, we need to update theLLM.generate
function signature and adapt theagenerate
method so function calls can be returned too #782 (I'll tackle this in a different PR).