Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating placement group when pipeline_parallel_size>1 #851

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

gabrielmbmb
Copy link
Member

Description

@gabrielmbmb gabrielmbmb added the fix label Aug 5, 2024
@gabrielmbmb gabrielmbmb added this to the 1.3.0 milestone Aug 5, 2024
@gabrielmbmb gabrielmbmb self-assigned this Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-851/

Copy link

codspeed-hq bot commented Aug 5, 2024

CodSpeed Performance Report

Merging #851 will not alter performance

Comparing fix-placement-group-for-spread (a7ce11a) with develop (bcbf6a1)

Summary

✅ 1 untouched benchmarks

@gabrielmbmb gabrielmbmb merged commit 79a07d5 into develop Aug 5, 2024
7 checks passed
@gabrielmbmb gabrielmbmb deleted the fix-placement-group-for-spread branch August 5, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant