Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set annotations+labels on pods created by argocd #1009

Conversation

AlexanderThaller
Copy link

@AlexanderThaller AlexanderThaller commented Sep 26, 2023

What type of PR is this?
/kind enhancement

What does this PR do / why we need it:

Allows adding additional annotations and labels to pods that are created by argocd.

Specifially need it to intigrate argocd and istio in an openshift environment.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #637

How to test changes / Special notes to the reviewer:

Gonna push the updated go code as an image to https://hub.docker.com/repository/docker/athallerde/argocd-operator/general

I have never updated a CRD so comments if I'm using the right types/format would be appreciated.

@svghadi
Copy link
Collaborator

svghadi commented Oct 3, 2024

Superseded by #1532

@svghadi svghadi closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to set annotations+labels on pods created by argocd
2 participants