Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add Server Ingress checks to apply the changes in case it exists #1553

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

nmirasch
Copy link
Contributor

@nmirasch nmirasch commented Oct 3, 2024

What type of PR is this?
/kind bug

What does this PR do / why we need it:
This PR adds logic to reconcile Server Ingress related changes in case it exists previously.

Which issue(s) this PR fixes:

Fixes #558
Fixes: https://issues.redhat.com/browse/GITOPS-5386

How to test changes / Special notes to the reviewer:
I performed an upgrade test as follows:

  1. Ran make run
  2. Created an ArgoCD CR.
  3. Check the Server Service Type is ClusterIP (by default)
  4. Do a kubectl apply on something like:
apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: argocd
spec:
  server:
    ingress:
      enabled: true
  1. Followed by a kubectl apply on something like:
apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: argocd
spec:
  server:
    host: foo.bar
    ingress:
      enabled: true
  1. Check the ingress have been updated with the new host value when describing the ingress

Copy link
Collaborator

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @nmirasch.

@anandrkskd
Copy link
Contributor

/lgtm

@svghadi svghadi merged commit 6e304b2 into argoproj-labs:master Oct 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing host does not update ingress
3 participants