feat(hydrator): enable controller #19539
Draft
+85,309
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crenshaw-dev
force-pushed
the
commit-server
branch
from
cb2feec
to
17d228e
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
6ce7dc0
to
e67e3ef
Compare
crenshaw-dev
force-pushed
the
commit-server
branch
from
17d228e
to
978b253
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
2 times, most recently
from
b642ed7
to
1168d9d
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
f5e91ef
to
40cdcf2
Compare
crenshaw-dev
force-pushed
the
commit-server
branch
from
978b253
to
a2ebf59
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
40cdcf2
to
d4fb401
Compare
crenshaw-dev
force-pushed
the
commit-server
branch
2 times, most recently
from
2d34f7f
to
5cc7db9
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
d4fb401
to
89bfa36
Compare
crenshaw-dev
force-pushed
the
commit-server
branch
from
5cc7db9
to
af7600a
Compare
Co-authored-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Omer Azmon <[email protected]> Co-authored-by: daengdaengLee <[email protected]> Co-authored-by: Juwon Hwang (Kevin) <[email protected]> Co-authored-by: thisishwan2 <[email protected]> Co-authored-by: mirageoasis <[email protected]> Co-authored-by: Robin Lieb <[email protected]> Co-authored-by: miiiinju1 <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> allow opt-in Signed-off-by: Michael Crenshaw <[email protected]> separation between app controller and hydrator Signed-off-by: Michael Crenshaw <[email protected]> simplify diff Signed-off-by: Michael Crenshaw <[email protected]> todos Signed-off-by: Michael Crenshaw <[email protected]> simplify Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
89bfa36
to
ad02bb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm breaking the hydrator into separate PRs. This is party to make them easier to review, partly because the commit history on the original PR is pretty messy at this point.
This PR is for the changes to the app controller to process the new sourceHydrator API + necessary tests.
I've added everyone who helped as a co-author on this PR.