Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable thelper linter #20405

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

mmorel-35
Copy link
Contributor

enables and fixes thelper linter issues.

Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35 mmorel-35 requested a review from a team as a code owner October 16, 2024 16:41
Copy link

bunnyshell bot commented Oct 16, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) October 16, 2024 16:57
@crenshaw-dev crenshaw-dev merged commit cc98925 into argoproj:master Oct 16, 2024
26 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/thelper branch October 16, 2024 17:37
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.05%. Comparing base (f031f49) to head (cb0dba1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20405      +/-   ##
==========================================
- Coverage   56.05%   56.05%   -0.01%     
==========================================
  Files         322      322              
  Lines       44798    44802       +4     
==========================================
+ Hits        25111    25112       +1     
- Misses      17087    17090       +3     
  Partials     2600     2600              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

4ch3los pushed a commit to 4ch3los/argo-cd that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants