Skip to content

Commit

Permalink
fix go vet by removing concurency
Browse files Browse the repository at this point in the history
Signed-off-by: zachaller <[email protected]>
  • Loading branch information
zachaller committed Jul 28, 2023
1 parent 1d5f0e3 commit 55c08ab
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions pkg/apis/rollouts/validation/validation_references_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,6 @@ func TestValidateRolloutReferencedResourcesNginxIngress(t *testing.T) {
}
}

// TODO: remove govet ignore rules
func TestValidateRolloutReferencedResourcesAlbIngress(t *testing.T) {
stableService := "stable-service-name"
wrongService := "wrong-stable-service"
Expand Down Expand Up @@ -1368,9 +1367,7 @@ spec:

routeTypes := []string{"httpRoute", "tcpRoute", "grpcRoute", "http2Route"}
for _, routeType := range routeTypes {
singleRouteType := routeType
t.Run(fmt.Sprintf("will succeed with valid appmesh virtual-router with %s", routeType), func(t *testing.T) {
t.Parallel()
manifest := fmt.Sprintf(`
apiVersion: appmesh.k8s.aws/v1beta2
kind: VirtualRouter
Expand All @@ -1389,7 +1386,7 @@ spec:
- virtualNodeRef:
name: mysvc-stable-vn
weight: 100
`, singleRouteType)
`, routeType)
obj := toUnstructured(t, manifest)
errList := ValidateAppMeshResource(*obj)
assert.NotNil(t, errList)
Expand Down

0 comments on commit 55c08ab

Please sign in to comment.