Skip to content

Commit

Permalink
copy var instead of removing Parallel
Browse files Browse the repository at this point in the history
Signed-off-by: zachaller <[email protected]>
  • Loading branch information
zachaller committed Jul 28, 2023
1 parent 07ebff2 commit 8e028f0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/apis/rollouts/validation/validation_references_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,9 @@ func TestValidateRolloutReferencedResourcesNginxIngress(t *testing.T) {
}

for _, test := range tests {
test := test
t.Run(test.name, func(t *testing.T) {
t.Parallel()
var ingresses []ingressutil.Ingress
for i, service := range test.services {
ingress := extensionsIngress(test.ingresses[i], 80, service)
Expand Down Expand Up @@ -612,7 +614,9 @@ func TestValidateRolloutReferencedResourcesAlbIngress(t *testing.T) {
}

for _, test := range tests {
test := test
t.Run(test.name, func(t *testing.T) {
t.Parallel()
var ingresses []ingressutil.Ingress
for i, service := range test.services {
ingress := extensionsIngress(test.ingresses[i], 80, service)
Expand Down
2 changes: 2 additions & 0 deletions rollout/trafficrouting/nginx/nginx_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,9 @@ func TestCanaryIngressAdditionalAnnotations(t *testing.T) {
func TestReconciler_canaryIngress(t *testing.T) {
tests := generateMultiIngressTestData()
for _, test := range tests {
test := test
t.Run(test.name, func(t *testing.T) {
t.Parallel()
// given
r := Reconciler{
cfg: ReconcilerConfig{
Expand Down

0 comments on commit 8e028f0

Please sign in to comment.