fix: isScalingEvent loop 1.7 #3889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…goproj#3519 (argoproj#3520) Fixed sha256 algo Signed-off-by: dhawani <[email protected]> Signed-off-by: dhawani <[email protected]> Co-authored-by: dhawani <[email protected]>
* fix: fallback to patch on scale conflict Signed-off-by: Zach Aller <[email protected]> fix: switch to retry logic Signed-off-by: Zach Aller <[email protected]> lint Signed-off-by: Zach Aller <[email protected]> retry experiments Signed-off-by: Zach Aller <[email protected]> remove TODO Signed-off-by: Zach Aller <[email protected]> remove accidental add Signed-off-by: Zach Aller <[email protected]> remove accidental add Signed-off-by: Zach Aller <[email protected]> add retry to setting revision Signed-off-by: Zach Aller <[email protected]> chore(deps): bump slsa-framework/slsa-github-generator from 1.10.0 to 2.0.0 (argoproj#3537) chore(deps): bump slsa-framework/slsa-github-generator Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 1.10.0 to 2.0.0. - [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases) - [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) - [Commits](slsa-framework/slsa-github-generator@v1.10.0...v2.0.0) --- updated-dependencies: - dependency-name: slsa-framework/slsa-github-generator dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump sigstore/cosign-installer from 3.4.0 to 3.5.0 (argoproj#3522) Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.4.0 to 3.5.0. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@e1523de...59acb62) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump golangci/golangci-lint-action from 4 to 5 (argoproj#3540) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 4 to 5. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v4...v5) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> docs: provide recommendation for strategies (argoproj#3531) * docs: provide recommendation for strategies Signed-off-by: Kostis (Codefresh) <[email protected]> * docs: traffic manager clarifications Signed-off-by: Kostis (Codefresh) <[email protected]> * docs: explain canary with/out traffic manager Signed-off-by: Kostis (Codefresh) <[email protected]> * docs: add 3 columns on the comparison table Signed-off-by: Kostis (Codefresh) <[email protected]> --------- Signed-off-by: Kostis (Codefresh) <[email protected]> feat(dashboard): change the color of the current rollout step (argoproj#3526) I feel that having the current (running) step in a orange color is misleading, as orange usually means warning. This commit changes the color to the `$argo-running-color`. Signed-off-by: Alejandro López Sánchez <[email protected]> chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch from 1.37.0 to 1.38.0 (argoproj#3525) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch Bumps [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) from 1.37.0 to 1.38.0. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.38.0/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.37.0...service/s3/v1.38.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> perform all of set revision actions on retry Signed-off-by: Zach Aller <[email protected]> fix variable Signed-off-by: Zach Aller <[email protected]> add retry counts to log Signed-off-by: Zach Aller <[email protected]> add retry counts to logs Signed-off-by: Zach Aller <[email protected]> clean logs, always dump controller e2e logs Signed-off-by: Zach Aller <[email protected]> lower timeout Signed-off-by: Zach Aller <[email protected]> bump timeout on e2e Signed-off-by: Zach Aller <[email protected]> retry on rollout conflict Signed-off-by: Zach Aller <[email protected]> don't reque on rs changes Signed-off-by: Zach Aller <[email protected]> reque rs Signed-off-by: Zach Aller <[email protected]> bump qps for e2e Signed-off-by: Zach Aller <[email protected]> fix gen-crd Signed-off-by: Zach Aller <[email protected]> switch to patch Signed-off-by: Zach Aller <[email protected]> switch to patch Signed-off-by: Zach Aller <[email protected]> add log Signed-off-by: Zach Aller <[email protected]> move log lines Signed-off-by: Zach Aller <[email protected]> Trigger Build Signed-off-by: Zach Aller <[email protected]> fix one e2e test Signed-off-by: Zach Aller <[email protected]> lint Signed-off-by: Zach Aller <[email protected]> add test Signed-off-by: Zach Aller <[email protected]> chore(deps): bump actions/setup-go from 5.0.0 to 5.0.1 (argoproj#3552) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v5.0.0...v5.0.1) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump codecov/codecov-action from 4.3.0 to 4.3.1 (argoproj#3550) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.3.0...v4.3.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(deps): bump google.golang.org/protobuf from 1.33.0 to 1.34.0 (argoproj#3548) Bumps google.golang.org/protobuf from 1.33.0 to 1.34.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> refactor Signed-off-by: Zach Aller <[email protected]> add test for updating rs revision Signed-off-by: Zach Aller <[email protected]> add retry for ephemeral metadata Signed-off-by: Zach Aller <[email protected]> clear some fields Signed-off-by: Zach Aller <[email protected]> add logs Signed-off-by: Zach Aller <[email protected]> refactor into function Signed-off-by: Zach Aller <[email protected]> change log Signed-off-by: Zach Aller <[email protected]> switch rollout update to patch fallback Signed-off-by: Zach Aller <[email protected]> siwtch ephemeral metadata sync to shared function Signed-off-by: Zach Aller <[email protected]> siwtch merge type Signed-off-by: Zach Aller <[email protected]> lint Signed-off-by: Zach Aller <[email protected]> don't update status Signed-off-by: Zach Aller <[email protected]> switch rollout update to not use patch Signed-off-by: Zach Aller <[email protected]> change log Signed-off-by: Zach Aller <[email protected]> switch to small patch Signed-off-by: Zach Aller <[email protected]> some cleanup Signed-off-by: Zach Aller <[email protected]> remove not found rollout removal Signed-off-by: Zach Aller <[email protected]> working setup Signed-off-by: Zach Aller <[email protected]> lint Signed-off-by: Zach Aller <[email protected]> fix test Signed-off-by: Zach Aller <[email protected]> small cleanup Signed-off-by: Zach Aller <[email protected]> * typo Signed-off-by: Zach Aller <[email protected]> * cleanup commented out code Signed-off-by: Zach Aller <[email protected]> * Trigger Build Signed-off-by: Zach Aller <[email protected]> * only patch rollouts manged fields Signed-off-by: Zach Aller <[email protected]> * lint Signed-off-by: Zach Aller <[email protected]> * fix flaky test Signed-off-by: Zach Aller <[email protected]> * fix flaky test Signed-off-by: Zach Aller <[email protected]> * reduce patch size Signed-off-by: Zach Aller <[email protected]> * get some logs Signed-off-by: Zach Aller <[email protected]> * cleanup Signed-off-by: Zach Aller <[email protected]> * improve tests Signed-off-by: Zach Aller <[email protected]> * Trigger Build Signed-off-by: Zach Aller <[email protected]> * add env var to log diff Signed-off-by: Zach Aller <[email protected]> * remove expirment rs patch Signed-off-by: Zach Aller <[email protected]> * imporve logs Signed-off-by: Zach Aller <[email protected]> * use correct variable Signed-off-by: Zach Aller <[email protected]> * change env var Signed-off-by: Zach Aller <[email protected]> * fix flaky e2e Signed-off-by: Zach Aller <[email protected]> * fix flaky e2e Signed-off-by: Zach Aller <[email protected]> * fix flaky e2e Signed-off-by: Zach Aller <[email protected]> * remove not found rollouts Signed-off-by: Zach Aller <[email protected]> * update replica count Signed-off-by: Zach Aller <[email protected]> * lint Signed-off-by: Zach Aller <[email protected]> * refactor cleanup Signed-off-by: Zach Aller <[email protected]> * keep track of UpdatedReplicas on sync Signed-off-by: Zach Aller <[email protected]> * some hpa tests and log changes Signed-off-by: Zach Aller <[email protected]> * remove update to UpdatedReplicas Signed-off-by: Zach Aller <[email protected]> * add more test Signed-off-by: Zach Aller <[email protected]> * fix test Signed-off-by: Zach Aller <[email protected]> * undo change Signed-off-by: Zach Aller <[email protected]> * add comment to flaky tests Signed-off-by: Zach Aller <[email protected]> * cleanup Makefile Signed-off-by: Zach Aller <[email protected]> * remove test Signed-off-by: Zach Aller <[email protected]> * use labels Signed-off-by: Zach Aller <[email protected]> * remove make file change Signed-off-by: Zach Aller <[email protected]> * add label to test Signed-off-by: Zach Aller <[email protected]> * review changes Signed-off-by: Zach Aller <[email protected]> * change to TODO Signed-off-by: Zach Aller <[email protected]> * fix test Signed-off-by: Zach Aller <[email protected]> * add extra logging for tests Signed-off-by: Zach Aller <[email protected]> * Trigger Build Signed-off-by: Zach Aller <[email protected]> * add ignore to codecov Signed-off-by: Zach Aller <[email protected]> * we always generate patch because we are comparing against emtpy obj Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
…goproj#3593 (argoproj#3603) fix protocol missing in ambassador canary mapping creation Signed-off-by: Joshua Mathew <[email protected]>
…y alb traffic management uses pingpong. (argoproj#3628) * fix: when Rollout has pingpong and stable/canary service defined, GetStableAndCanaryServices returns based on isPingpongPreferred. Only when it is ALB controller, then isPringpongPreferred is true. Signed-off-by: mayz985 <[email protected]> * fix lint error Signed-off-by: mayz985 <[email protected]> * added e2e Signed-off-by: mayz985 <[email protected]> --------- Signed-off-by: mayz985 <[email protected]>
…#3627) * fix: verify the weight of the alb at the end of the rollout when we auto set max weight Signed-off-by: Zach Aller <[email protected]> * add unit test Signed-off-by: Zach Aller <[email protected]> * refactor add unit test Signed-off-by: Zach Aller <[email protected]> * Trigger Build Signed-off-by: Zach Aller <[email protected]> * Trigger Build Signed-off-by: Zach Aller <[email protected]> * block reconcile Signed-off-by: Zach Aller <[email protected]> * add tests Signed-off-by: Zach Aller <[email protected]> * rename test and cleanup un-need logic check Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Tommy Chen <[email protected]>
* fix: don't default datadog aggregator Signed-off-by: Zach Aller <[email protected]> * codegen Signed-off-by: Zach Aller <[email protected]> * fix: don't default datadog aggregator Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: xiaowu.zhu <[email protected]> Signed-off-by: root <[email protected]>
…ixes argoproj#3366 (argoproj#3639) * Update pod status logic to support native sidecars Signed-off-by: Martyn Dale <[email protected]> * Fix lint issues Signed-off-by: Martyn Dale <[email protected]> --------- Signed-off-by: Martyn Dale <[email protected]>
argoproj#3664) * fix(controller): use the stableRS from the rollout context rather than inferring it from the active selector, to deal with the edge case where the stableRS != activeRS during analysis templates Signed-off-by: ben.minter <[email protected]> * fix(controller): update tests which were relying on this bug(?) Signed-off-by: ben.minter <[email protected]> * fix(controller): add clarity to comment in the case there is no stableRS Signed-off-by: ben.minter <[email protected]> * fix(controller): add a test to assert that the stablers is not scaled by the reconiliation on start, by checking the log Signed-off-by: ben.minter <[email protected]> --------- Signed-off-by: ben.minter <[email protected]>
…ysis Runs. Fixes argoproj#3669 (argoproj#3670) * Ensure that BackgroundAnalysisRun does not run when rolling back within RollbackWindow Signed-off-by: Alex Dunn <[email protected]> * Fix linting Signed-off-by: Alex Dunn <[email protected]> --------- Signed-off-by: Alex Dunn <[email protected]>
…Fixes argoproj#3672 (argoproj#3675) fix: add update verb to ClusterRole permissions for scaleDown Signed-off-by: EnriqueTejeda <[email protected]>
…rgoproj#3730) * Datadog: explicitly set aggregator to last the field is required by API and we currently leave it empty string Signed-off-by: Alex Eftimie <[email protected]> * add unit tests Signed-off-by: Alex Eftimie <[email protected]> --------- Signed-off-by: Alex Eftimie <[email protected]>
…proj#3615 (argoproj#3759) Signed-off-by: BrunoTarijon <[email protected]>
) The current code creates a new http.Transport for each http.Client that is created, which leads to a leak in TCP connections due to keep-alive. Instead, reuse the same http.Transport between requests. According to the http.Transport docs, this is safe for concurrent use. Signed-off-by: Kevin Ji <[email protected]>
…j#3762) (argoproj#3784) dco Signed-off-by: Alexandre Gaudreault <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".