Sort pairs by latitude #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dictionary is sorted by
azimuthZeroDopplerMidTime(see here), which is derived from just the filename to save time from cracking the product open.But in some cases it’s the same value for adjacent frames (e.g.
S1-GUNW-A-R-033-tops-20170217_20150815-225114-00076W_00040N-PP-413c-v3_0_0.ncandS1-GUNW-A-R-033-tops-20170217_20150815-225114-00076W_00041N-PP-d372-v3_0_0.nc) and the frames are then flipped around in sorting, leading to a false positive in that the program rejects these pairs due to an apparent gap.@bbuzz31 you can confirm this patch now avoids this behavior by appropriately passing all of the "2017" pairs in the subdirectory you shared by running the following command: