-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fatal error if not in git dir #109
Conversation
Same bug occurs on openSUSE with git 2.13.0. |
looks like its not an actual bug, but git added some error messages when you use git in non-git folders |
Thanks I was seeing this too, linuxbrew after update to 2.13.0. Please merge :-) #110 is a dupe of this bug. |
Tested locally.. Thanks for the fix, @cy4n . LGTM. |
Message changed from |
actually skipping --local would also allow to globally disable oh-my-git by adding
to the global ~/.gitconfig
in the local .git/config |
approved @huxi ;) |
param is not needed and provides an error message if called from non-git folder
When will this PR be merged into master? I would rather take the changes from master than be running a side branch. |
github says that @arialdomartini is still active,) ask him. |
Cheers @cy4n I have pinged him, hopefully we can get this approved and merged. |
Any news on this @arialdomartini ? |
Refers to PR arialdomartini#109. * cyan4/fix_enabled: remove --local param
Hello! Are there any news on this? @arialdomartini |
@cy4n, @UFOMelkor, @djbclark, @borja, @huxi, @andrewkew-aft, @snowblink, @MindRave shame on me. I've been neglecting this repo for more than 1 year already. I've got a bunch of issues to fix and pull requests to merge. Time to get up and work. |
@arialdomartini before you merge all this PRs, maybe checkout my or @compholios fork, because we have picked some of the PRs and received PRs on top of them that are not necessarily in your upstream repo |
anyway welcome back |
Hi @cy4n. I think I will go with the former. Keep in touch, please, I'm going to ask your opinion on some PRs... Grazie mille! |
upgrade in git changed viability of --local fix found via upstream commit arialdomartini#109 (comment)
following command throws an error in git 2.13.0 macosx:
this fix pipes the "fatal..." output to /dev/null (as you already do in every other git command :-)