refactor

app/controllers/slack_controller.rb

@@ -34,7 +34,7 @@ def givers
   end
 
   def leaderboard
-    render json: SlackMessages.leaderboards(Leaderboards.new(team))
+    render json: SlackMessages.leaderboards(Leaderboards::TextPresenter(Leaderboards.new(team)))
   end
 
   private

app/models/leaderboards.rb

@@ -25,12 +25,23 @@ def aggreated_data(scope)
       .limit(10)
       .sum('points')
       .group_by(&:second)
-      .then(&method(:format))
+      .map { |points, members| [points, members.map(&:first)] }.to_h
   end
 
-  def format(hash)
-    hash
-      .map { |count, members| "#{count}: #{members.map(&:first).join(", ")}" }
-      .join("\n")
+  class TextPresenter
+    def initialize(leaderboards)
+      @leaderboards = leaderboards
+    end
+
+    def method_missing(m, *args, &block)
+      @leaderboards.respond_to?(m) ? format(@leaderboards.public_send(m)) : super
+    end
+
+    private
+    def format(hash)
+      hash
+        .map { |count, members| "#{count}: #{members.join(", ")}" }
+        .join("\n")
+    end
   end
 end

test/models/leaderboards_test.rb

@@ -12,7 +12,8 @@ class LeaderboardsTest < ActiveSupport::TestCase
     GiveUpvote.new.call('dudu', '+1 kaka', '+1', team)
     GiveUpvote.new.call('kaka', '+1 dudu', '+1', team)
 
-    assert_equal <<~RESULT.strip, Leaderboards.new(team).top_for_this_month
+    assert_equal({ 2 => ["kaka"], 1 => ["dudu"] }, Leaderboards.new(team).top_for_this_month)
+    assert_equal <<~RESULT.strip, Leaderboards::TextPresenter.new(Leaderboards.new(team)).top_for_this_month
       2: kaka
       1: dudu
     RESULT
@@ -29,7 +30,8 @@ class LeaderboardsTest < ActiveSupport::TestCase
     GiveUpvote.new.call('dudu', '+1 kaka', '+1', team)
     GiveUpvote.new.call('kaka', '+1 dudu', '+1', team)
 
-    assert_equal <<~RESULT.strip, Leaderboards.new(team).top_for_this_week
+    assert_equal({ 2 => ["kaka"], 1 => ["dudu"] }, Leaderboards.new(team).top_for_this_week)
+    assert_equal <<~RESULT.strip, Leaderboards::TextPresenter.new(Leaderboards.new(team)).top_for_this_week
       2: kaka
       1: dudu
     RESULT