Add s.f display format option #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds 24 frame per second time suffix option Decided against adding configurable fps setting or even formats with minutes because I couldn't find evidence that use cases exist. For animation timing, it's for pre-visualizing storyboard shots, thus minutes are too long. Additionally, 24 fps seems like the dominant standard, and going beyond that opens a can of works for a huge number of (potentially non-integer) frame rates to support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided against adding configurable fps setting or even formats with minutes because I couldn't find evidence that use cases exist. For animation timing, it's for pre-visualizing storyboard shots, thus minutes are too long. Additionally, 24 fps seems like the dominant standard, and going beyond that opens a can of works for a huge number of (potentially non-integer) frame rates to support.