Update dependencies to latest version, include CDI EL API #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI updates are because of older JDK versions in the CI - some of the dependencies are on JDK 17 as min. EDIT: should be addressed now. |
starksm64
requested changes
Jan 4, 2024
pom.xml
Outdated
| @@ -33,15 +33,15 @@ | |||
| <version.arquillian_core>1.7.0.Alpha10</version.arquillian_core> | |||
There was a problem hiding this comment.
Update this to <version.arquillian_core>1.8.0.Final</version.arquillian_core> so we pickup the breakout of the Jakarta EE apis from core.
There was a problem hiding this comment.
Ah, good catch, forgot about that one!
Fixed now
|
@manovotn Yes, just update the core version and this should be good. |
starksm64
approved these changes
Jan 4, 2024
|
4.0.0.Final has been released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117
Even though I linked this to #117 the main reason for this update is to include the CDI EL API artifact, otherwise testing will fail with latest Weld.
The updates also mean this version will target next EE version so we might want to bump up major version of this project?
I'll also need a release (doesn't need to be Final) in order to bump the version in Weld.
Do you think you could do that @starksm64?