Use PHP memory limit setting for CentOS/RHEL #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jraddaoui
reviewed
Apr 13, 2021
| lineinfile: | ||
| path: /etc/opt/rh/rh-php{{ php_version }}/php.ini | ||
| regexp: '^memory_limit' | ||
| line: 'memory_limit = 512M' | ||
| line: 'memory_limit = {{ atom_pool_php_memory_limit }}' |
There was a problem hiding this comment.
@replaceafill, we need to do some extra changes on php.ini and I found this PR. I think we should allow this modification in Ubuntu too and have different values for the pool and php.ini. Please, let me know your thoughts, I could take it if you want ;)
There was a problem hiding this comment.
@jraddaoui I discussed this with @mamedin and realized it's not the right approach for the issue. So I think we should close this one if that's OK with you (I forgot to close it a few weeks ago).
There was a problem hiding this comment.
Sounds good, I'll chat with @mamedin too, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #65