workflow: do not retry AM poll activities

This commit updates the poller activities so they convert errors that escape the backoff retry into workflow NRE (non-retryable) errors. When these are returned, they escape the retry policy attached to the activities. E.g., we want the activity to give up right away when Archivematica returns the "FAILED" status for a package.
artefactual-labs · Nov 7, 2019 · 6f8e9af · 6f8e9af
1 parent c528595
commit 6f8e9af
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/workflow/poll_ingest_activity.go b/internal/workflow/poll_ingest_activity.go
@@ -33,7 +33,7 @@ func (a *PollIngestActivity) Execute(ctx context.Context, tinfo *TransferInfo) (
 
 			err = pipeline.IngestStatus(ctx, amc, tinfo.SIPID)
 			if errors.Is(err, pipeline.ErrStatusNonRetryable) {
-				return backoff.Permanent(err)
+				return backoff.Permanent(nonRetryableError(err))
 			}
 
 			return err

diff --git a/internal/workflow/poll_transfer_activity.go b/internal/workflow/poll_transfer_activity.go
@@ -34,7 +34,7 @@ func (a *PollTransferActivity) Execute(ctx context.Context, tinfo *TransferInfo)
 
 			sipID, err = pipeline.TransferStatus(ctx, amc, tinfo.TransferID)
 			if errors.Is(err, pipeline.ErrStatusNonRetryable) {
-				return backoff.Permanent(err)
+				return backoff.Permanent(nonRetryableError(err))
 			}
 
 			return err