Fix API key generation when user edits are disabled #2004
Merged
+484
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test submits the user profile form leaving the "Regenerate API key" field unchecked. The test fails because the API key is always updated on POST submission when the ALLOW_USER_EDITS setting is False.
This updates the ApiKeyForm to use boolean values instead of characters and the profile view to use the cleaned_data attribute of the form to check if API key regeneration was requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ALLOW_USER_EDITS setting of the Dashboard is set to
Falsethe user profile view shows most fields as read-only but allows the user to regenerate their API key.However, submission handling of the form is currently broken and the API key is always regenerated when the
Savebutton is clicked ignoring the state of theRegenerate API keycheckbox.This also extends test coverage of the views of the
accountsandadministrationpackages.