Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs about search box defaults (#236) #241

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

anvit
Copy link
Contributor

@anvit anvit commented Oct 23, 2023

Update the docs to remove references to having the institutional search being the default option, since AtoM now defaults to global search.

@anvit anvit added the user manual The issue affects content in the User manual label Oct 23, 2023
@anvit anvit added this to the 2.8 milestone Oct 23, 2023
@anvit anvit self-assigned this Oct 23, 2023
@anvit anvit linked an issue Oct 23, 2023 that may be closed by this pull request
Copy link
Contributor

@melaniekung melaniekung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks but otherwise LGTM!

:ref:`below <search-using-delimiters>` for further instructions on using
the search box delimiters.
the search box (in a Bootstrap 2 theme) or clicking the gear icon
(in Bootstrap 5 themes) will reveal a set of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick but i think (in a Bootstrap 2 theme) and (in Bootstrap 5 themes) should be consistent, ex (in a Bootstrap 2 theme) and (in a Bootstrap 5 theme) or (in Bootstrap 2 themes) and (in Bootstrap 5 themes)

the search box (in a Bootstrap 2 theme) or clicking the gear icon
(in Bootstrap 5 themes) will reveal a set of
:term:`radio buttons <radio button>` that allow the user limit the search
results to the holdings of the most recently viewed :term:`archival institution`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another nitpick - that allow the user to limit the search results of the holdings?

Update the docs to remove references to having the institutional search
being the default option, since AtoM now defaults to global search.
@anvit anvit force-pushed the dev/issue-236-search-box-updates branch from 2a5c57c to 036f8b1 Compare October 25, 2023 19:20
@anvit anvit changed the base branch from 2.7 to 2.8 November 20, 2023 21:59
@anvit anvit merged commit cb8c449 into 2.8 Nov 20, 2023
2 checks passed
@anvit anvit deleted the dev/issue-236-search-box-updates branch November 20, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user manual The issue affects content in the User manual
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update search docs to reflect changes to institutional search
2 participants