Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update settings.rst for items per page limit ref#266 #276

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Update settings.rst for items per page limit ref#266 #276

merged 1 commit into from
Apr 5, 2024

Conversation

Jennoit
Copy link
Contributor

@Jennoit Jennoit commented Mar 27, 2024

Changed the default installation value for items per page limit from 50 to 8000. This is issue ref#266.

@Jennoit
Update settings.rst for items per page limit ref#266
ffb784d 
Changed the default  installation vaue for items per page limit from 50 to 8000.
anvit
anvit approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@anvit anvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Jennoit ! Thank you!

@anvit
Copy link
Contributor

anvit commented Apr 2, 2024

Oh @Jennoit, minor nitpick — we usually just have #xyz in our commit messages instead of ref#xyz to refer to the issue. This helps GitHub make it a clickable link pointing to the corresponding issue.

@Jennoit
Copy link
Contributor Author

Jennoit commented Apr 2, 2024

Thanks for the clarification @anvit - will do next time.

@anvit anvit merged commit d238a43 into artefactual:2.8 Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anvit anvit anvit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jennoit @anvit