Fix delete function of 'Lang and script note'. (#1846) (#1866)

Update delete function for 'Language and script note' field to delete entry from database and removing duplicate check for deleted entry.
artefactual · Sep 16, 2024 · 4926bc9 · 4926bc9
1 parent 199d159
commit 4926bc9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/lib/model/om/BaseNote.php b/lib/model/om/BaseNote.php
@@ -405,7 +405,7 @@ public function save($connection = null)
   {
     if ($this->deleted)
     {
-      throw new PropelException('You cannot save an object that has been deleted.');
+      return $this;
     }
 
     if ($this->new)

diff --git a/plugins/sfIsadPlugin/lib/sfIsadPlugin.class.php b/plugins/sfIsadPlugin/lib/sfIsadPlugin.class.php
@@ -77,13 +77,6 @@ public function __set($name, $value)
                 if (0 == strlen($value)) {
                     // Delete note if it's available
                     if (!$missingNote) {
-                        // Update deleted note on duplication
-                        if (!isset($value)) {
-                            $note->content = $value;
-
-                            break;
-                        }
-
                         $note->delete();
                     }