Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artex master #7

Open
wants to merge 95 commits into
base: master
Choose a base branch
from
Open

Artex master #7

wants to merge 95 commits into from

Commits on Dec 18, 2023

  1. Bump golang.org/x/crypto from 0.15.0 to 0.17.0

    Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.17.0.
    - [Commits](golang/crypto@v0.15.0...v0.17.0)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/crypto
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    7fadeb5 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Configuration menu
    Copy the full SHA
    3594015 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Escape send queued when blocked on connection side

    use default instead of a timer
    
    refactor send queued
    
    In case of Log On messages block until sent
    AlexandrosKyriakakis committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d7f2968 View commit details
    Browse the repository at this point in the history
  2. merge

    AlexandrosKyriakakis committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    5dcde41 View commit details
    Browse the repository at this point in the history
  3. Bug: For Logon/Logout/Resend/SequenceReset messages we should wait un…

    …til sent (quickfixgo#21)
    
    ## Issue 
    When log on request was queued because cannot be send due to connection
    not ready,
    Then it goes through the [main session
    loop](https://github.com/alpacahq/quickfix/blob/5dcde41f3e6e68e93e1fd381761cd9c7843aec43/session.go#L821-L841)
    which leads to
    [SendAppMessages](https://github.com/alpacahq/quickfix/blob/5dcde41f3e6e68e93e1fd381761cd9c7843aec43/session_state.go#L107-L111)
    
    But, since session is not logged on yet because the message queued is
    the log on message, we drop the `toSend` queued messages so we lose the
    log on message itself.
    
    
    ## Proposed solution
    For important messages like Logon/Logout/Resend/SequenceReset we block
    until sent.
    AlexandrosKyriakakis authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    6eaa8ce View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. add test for multiple repeating groups in a message

    partly revert change in quickfixgo#368 due to breaking the unit test added in this PR
    albert committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    de36465 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Update linter

    ackleymi committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    aa39aa8 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Statify updated linter rules

    ackleymi committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a203213 View commit details
    Browse the repository at this point in the history
  2. Merge pull request quickfixgo#626 from ackleymi/main

    Update and satisfy code linter
    ackleymi authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    9886e68 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge pull request quickfixgo#623 from albertsundjaja/group-stack-adv…

    …anced-incorrectly
    
    Group field whose elements do not have the same fields are incorrectly parsed
    ackleymi authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e155413 View commit details
    Browse the repository at this point in the history
  2. Merge pull request quickfixgo#615 from alpacahq/escape-send-queued-wh…

    …en-blocked
    
    Escape send queued when blocked on connection side
    ackleymi authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    51e2cde View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    96baad8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1518a20 View commit details
    Browse the repository at this point in the history
  5. Merge pull request quickfixgo#627 from haoyang1994/feat/proxy_v2

    feat: change proxyproto pkg to support proxy proto v2
    ackleymi authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b7e2597 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    ab04145 View commit details
    Browse the repository at this point in the history
  2. Merge pull request quickfixgo#628 from alpacahq/develop

    Bug: For Logon/Logout/Resend/SequenceReset messages we should wait until sent
    ackleymi authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    21eab6b View commit details
    Browse the repository at this point in the history
  3. Merge pull request quickfixgo#606 from quickfixgo/dependabot/go_modul…

    …es/golang.org/x/crypto-0.17.0
    
    Bump golang.org/x/crypto from 0.15.0 to 0.17.0
    ackleymi authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    8304be5 View commit details
    Browse the repository at this point in the history
  4. Update deps

    ackleymi committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ad9438a View commit details
    Browse the repository at this point in the history
  5. v0.9.2 release notes

    ackleymi committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    2f15490 View commit details
    Browse the repository at this point in the history
  6. Merge pull request quickfixgo#630 from ackleymi/v092-release

    Adds v0.9.2 release notes
    ackleymi authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    2c25e08 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Configuration menu
    Copy the full SHA
    e2a2f27 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74fd67b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b9e203b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Merge pull request quickfixgo#632 from haoyang1994/tag_check_options

    feat: AllowUnknownMessageFields & CheckUserDefinedFields
    ackleymi authored Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c3c49cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0256864 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge pull request quickfixgo#635 from ackleymi/initiator-logon-reset

    Corrects ResetOnLogon for initiators
    ackleymi authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c187bdb View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Configuration menu
    Copy the full SHA
    d591447 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Configuration menu
    Copy the full SHA
    6659865 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf3fb98 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge pull request quickfixgo#637 from SNORRIS721/duplicatesession

    Unregistering sessions on stop
    ackleymi authored May 7, 2024
    Configuration menu
    Copy the full SHA
    1205f67 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Configuration menu
    Copy the full SHA
    668e1f4 View commit details
    Browse the repository at this point in the history
  2. fixing msgdef type error

    SNORRIS721 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    ff456d7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    60846b9 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge pull request quickfixgo#639 from SNORRIS721/mapcrash

    Changing filestore.offsets from map[int]msgDef to sync.Map
    ackleymi authored May 9, 2024
    Configuration menu
    Copy the full SHA
    807c9fe View commit details
    Browse the repository at this point in the history
  2. v0.9.3 release notes

    ackleymi authored May 9, 2024
    Configuration menu
    Copy the full SHA
    fbe0cd7 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    6889cf1 View commit details
    Browse the repository at this point in the history
  2. Linter fixes

    ackleymi committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3517c8b View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Adds log to readLoop

    ackleymi committed May 17, 2024
    Configuration menu
    Copy the full SHA
    525b62c View commit details
    Browse the repository at this point in the history
  2. Adds nullLog

    ackleymi committed May 17, 2024
    Configuration menu
    Copy the full SHA
    035d82e View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge pull request quickfixgo#636 from ackleymi/repeating-grps

    Maintain repeating group field order when parsing messages
    ackleymi authored May 30, 2024
    Configuration menu
    Copy the full SHA
    2da4180 View commit details
    Browse the repository at this point in the history
  2. Merge pull request quickfixgo#642 from ackleymi/add-log

    Adds log to readLoop just like writeLoop
    ackleymi authored May 30, 2024
    Configuration menu
    Copy the full SHA
    7a5765f View commit details
    Browse the repository at this point in the history
  3. v0.9.4 release notes

    ackleymi committed May 30, 2024
    Configuration menu
    Copy the full SHA
    7e71cbc View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Configuration menu
    Copy the full SHA
    c855c33 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Configuration menu
    Copy the full SHA
    a60af80 View commit details
    Browse the repository at this point in the history
  2. Merge pull request quickfixgo#645 from momin-javed/increment-target-seq

    Do not increment NextTargetMsgSeqNum for out of sequence Logout and Test Requests
    ackleymi authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    358abef View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Configuration menu
    Copy the full SHA
    91700d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a420261 View commit details
    Browse the repository at this point in the history
  3. Merge pull request quickfixgo#649 from ackleymi/cfg-fixes

    Port config documentation into proper go doc format
    ackleymi authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f6ff247 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    1c2db3a View commit details
    Browse the repository at this point in the history
  2. Merge pull request quickfixgo#27 from ackleymi/add-missing-test-defs

    Adds resendreqchunksize and lastseqnumprocessed test suites
    ackleymi authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ab7cd32 View commit details
    Browse the repository at this point in the history
  3. Merge pull request quickfixgo#650 from ackleymi/main

    Adds resendreqchunksize and lastseqnumprocessed test suites, refactors test runners
    ackleymi authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e3a2994 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Use bytes.Count to count the number of message fields

    Not a huge improvement but an improvement nonetheless.
    
    ```
    goos: darwin
    goarch: arm64
    pkg: github.com/quickfixgo/quickfix
                   │    old3     │                new3                │
                   │   sec/op    │   sec/op     vs base               │
    ParseMessage-8   680.6n ± 0%   650.0n ± 0%  -4.49% (p=0.000 n=20)
    ```
    
    Signed-off-by: Sylvain Rabot <[email protected]>
    sylr committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    3c66554 View commit details
    Browse the repository at this point in the history
  2. Optimize tag value parsing

    ```
    goos: darwin
    goarch: arm64
    pkg: github.com/quickfixgo/quickfix
                   │     old     │          new-no-indexbyte          │
                   │   sec/op    │   sec/op     vs base               │
    ParseMessage-8   695.2n ± 1%   628.2n ± 1%  -9.64% (p=0.000 n=20)
    ```
    
    Signed-off-by: Sylvain Rabot <[email protected]>
    sylr committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f725b98 View commit details
    Browse the repository at this point in the history
  3. Only lock fieldmap once during message parsing

    ```
    goos: darwin
    goarch: arm64
    pkg: github.com/quickfixgo/quickfix
                   │     old     │          new-parse-no-lock          │
                   │   sec/op    │   sec/op     vs base                │
    ParseMessage-8   695.2n ± 1%   591.0n ± 0%  -14.99% (p=0.000 n=20)
    ```
    
    Signed-off-by: Sylvain Rabot <[email protected]>
    sylr committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    af66cc8 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Fix stuck call to Dial when calling Stop on the initiator

    This commit fixes an issue when calling Start() and then
    Stop() on the initiator while the connection is likely
    to fail and timeout. Calling initiator.Stop() will block since
    Dial will attempt to connect until it times out and returns
    on the 'waitForReconnectInterval' call.
    
    We mitigate this problem by using a proxy.ContextDialer and
    allowing to pass a context with cancellation method to the
    dialer.DialContext method on 'handleConnection'.
    
    We need to start a routine listening for the stopChan in
    order to call cancel() explicitly and thus exit the DialContext
    method.
    
    Note: there are scenarios where cancel() will be called twice,
    this choice was made in order to avoid a larger refactor of the
    reconnect logic, but since the call to cancel() is idempotent,
    this doesn't lead to any adverse effect.
    
    fixes quickfixgo#653
    
    Signed-off-by: Alexandre Beslic <[email protected]>
    abronan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3939268 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Introduce message iterator to avoid loading all messages into memory …

    …at once upon resend request
    michaelwilner committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    ad74d03 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Use the Go generated file convention.

    This commit updates the template to include the recommended convention
    for generated files, specifically a string that matches the regex:
    
    ```
    ^// Code generated .* DO NOT EDIT\.$
    ```
    
    This change should make easier certain housekeeping tasks, specifically
    allowing things like linting tools to ignore these files. See
    https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source for
    a canonical source for this recommendation.
    smulube committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    1289a47 View commit details
    Browse the repository at this point in the history
  2. Support TLS configuration as raw bytes

    This change is intended to allow users to configure TLS settings in the
    form of raw byte slices. This is particularly useful for situations
    where the FIX application is running in a cloud environment (e.g. k8s)
    and session configuration is loaded from a database (rather than a
    static file). In this scenario it is much more convenient to be able to
    load TLS key pairs from the DB in the form of byte slices, than to have
    to ensure files with the correct names exist on some persistent volume
    such that the FIX app can load them from disk correctly.
    
    To support this we changed the basic type stored within SessionSettings
    to be a byte slice which means we are able to still support the existing
    settings model, but also handle raw byte slices we can use for TLS
    setup. The existing API exposed by SessionSettings remains unchanged
    meaning users should not have to update their codee, but we have added a
    new `SetRaw` and `RawSetting` accessors to directly read/write byte
    slice values.
    smulube committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d3b4f98 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Configuration menu
    Copy the full SHA
    7fe4ce2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c07597e View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Merge pull request quickfixgo#654 from abronan/mitigate-stuck-dial-on…

    …-initiator-stop
    
    Fix stuck call to Dial when calling Stop on the Initiator
    ackleymi authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e92fa68 View commit details
    Browse the repository at this point in the history
  2. Merge pull request quickfixgo#655 from sylr/parse2

    Use bytes.Count to count the number of message fields
    ackleymi authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f69f9f9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request quickfixgo#657 from sylr/no-indexbyte

    Optimize tag value parsing
    ackleymi authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f8a53b0 View commit details
    Browse the repository at this point in the history
  4. Merge pull request quickfixgo#658 from sylr/parse-no-lock

    Only lock fieldmap once during message parsing
    ackleymi authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    6e564c1 View commit details
    Browse the repository at this point in the history
  5. Merge pull request quickfixgo#647 from appital/tls-bytes

    Support TLS configuration as raw bytes
    ackleymi authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    9191a58 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. v0.9.5 release notes

    ackleymi authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2e60bad View commit details
    Browse the repository at this point in the history
  2. Merge pull request quickfixgo#663 from quickfixgo/ackleymi-patch-1

    v0.9.5 release notes
    ackleymi authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    8a53aa9 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Configuration menu
    Copy the full SHA
    26dc502 View commit details
    Browse the repository at this point in the history
  2. lint fix

    ekovacs committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    aa31991 View commit details
    Browse the repository at this point in the history
  3. cleanup

    ekovacs committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    6e397ee View commit details
    Browse the repository at this point in the history
  4. adjust comments

    ekovacs committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    f4d6fe9 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Configuration menu
    Copy the full SHA
    aa15928 View commit details
    Browse the repository at this point in the history
  2. Satisfies linter

    ackleymi committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    fdcb6a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Merge pull request quickfixgo#667 from ekovacs/feature/allow-custom-t…

    …ls-config-for-acceptor
    
    Allow the clients of acceptor to specify their own tls.Config
    ackleymi authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5ec1219 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge pull request quickfixgo#668 from ackleymi/add-missing-test-defs

    Adds NextExpectedSeqNum setting
    ackleymi authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0f3ec7b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    87eef54 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Merge pull request quickfixgo#669 from ackleymi/prevent-deadlock

    Reinit stop sync to prevent deadlock on sequential start/stops
    ackleymi authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    fa2e438 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7194eee View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Modify msg verify checks

    ackleymi committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    2e7e077 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Resolve failing unit test

    ackleymi committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    dc7a7bf View commit details
    Browse the repository at this point in the history
  2. Linter

    ackleymi committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    fad0176 View commit details
    Browse the repository at this point in the history
  3. Linter fix

    ackleymi committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f1f8c0e View commit details
    Browse the repository at this point in the history
  4. Adds unit test

    ackleymi committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bb3e854 View commit details
    Browse the repository at this point in the history
  5. Merge pull request quickfixgo#670 from ackleymi/prevent-store-reset-u…

    …nauth
    
    Check logon auth before resetting store
    ackleymi authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2903198 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    393a748 View commit details
    Browse the repository at this point in the history
  2. Merge pull request quickfixgo#674 from ackleymi/toadmin-fix

    Reverts ToAdmin call sequencing
    ackleymi authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b7fa96b View commit details
    Browse the repository at this point in the history
  3. Adds v0.9.6 release notes

    ackleymi committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b7d706f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9c5d08c View commit details
    Browse the repository at this point in the history
  5. Adds more tests

    ackleymi committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f01e28e View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Adds composite log

    ackleymi committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b781a85 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Merge pull request quickfixgo#672 from ackleymi/new-log-impls

    Adds SQL, Mongo, and Composite Log Implementations
    ackleymi authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c2cd79a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    90867a2 View commit details
    Browse the repository at this point in the history
  3. Merge pull request quickfixgo#675 from ackleymi/interface-getters

    Adds convenience getters for session log and store
    ackleymi authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c7392e8 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Configuration menu
    Copy the full SHA
    698d100 View commit details
    Browse the repository at this point in the history
  2. Fix mongodb store tests in CI

    Signed-off-by: Sylvain Rabot <[email protected]>
    sylr committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1a64a6c View commit details
    Browse the repository at this point in the history