feat: masonry #138
Merged
feat: masonry #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
gkartalis
requested review from
damassi,
MrSltun,
brainbicycle,
araujobarret and
MounirDhahri
artsy-peril
bot
added
the
Jira Synced
|
That network connection issue is often an ephemeral thing... give it a sec! |
|
PR Got merged, making sure that everything works after I publish the canary. In theory we might not need the flashlist pr to get merged (tested it out without the flashlist patch on the collapsible tab view lib and was working great!) |
|
Published canary version: 12.0.2--canary.138.576.0 |
|
UPDATE: we don't need the flashlist PR for this to work, we only need it for the type to be happy and to remove the expect ts error from the collapsible tab library! |
joeyAghion
approved these changes
Aug 10, 2023
gkartalis
force-pushed
the
gkartalis/masonry
branch
from
502d168
to
9f7b95c
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves PHIRE-3
Description
Masonry support for tabs.
In order to make masonry work properly without flashes and re-rendering issues had to do two PRs to our dependencies.
One to
react-native-collapsible-tab-viewand one on@shopify/flash-listThe current PR points to both of my forks just to make sure that it actually solves our issue and it does!
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
Follow ups:
Next steps:
How do you think we should proceed with this? It's ready but we are depending on both libraries on merging the PRs.
distfolder of the library since it throws errors because dist was in gitignore.Not sure how to unblock this to publish a canary 🤔 Ci fails with error:
info There appears to be trouble with your network connection. Retrying...But people in stackoverflow say that this might happen for either no network connection on ci or even having a huge package (first thing that comes to mind is that this is due to me including the dist folder)
Happy to hear your thoughts.
How to run - test
yarn local-palette-devon this branchgkartalis/masonrygkartalis/masonryand also runyarn local-palette-devDemo from eigen
It is missing the filter sticky header but can be really easily added 🔥
Simulator.Screen.Recording.-.iPhone.14.Plus.-.2023-08-08.at.19.11.38.mp4
📦 Published PR as canary version:
13.0.0--canary.138.614.0✨ Test out this PR locally via: