Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ask msvc to report the correct C++ version in __cplusplus macro #7545

Merged
merged 1 commit into from
Jun 30, 2024
Merged

ask msvc to report the correct C++ version in __cplusplus macro #7545

merged 1 commit into from
Jun 30, 2024

Conversation

arvidn
Copy link
Owner

@arvidn arvidn commented Nov 14, 2023 •
edited
Loading

context: #7534

@arvidn arvidn closed this Nov 15, 2023
@arvidn arvidn reopened this Nov 15, 2023
@arvidn
Copy link
Owner Author

arvidn commented Nov 15, 2023

it appears this is causing simulations to fail on windows. needs more investigation

@arvidn arvidn force-pushed the msvc-cxx-version branch 2 times, most recently from e0d7b53 to 7f64e97 Compare November 15, 2023 20:23
@arvidn arvidn closed this Jun 13, 2024
@arvidn arvidn reopened this Jun 13, 2024
@xavier2k6
Copy link
Contributor

/Zc\:__cplusplus - shouldn't this be /Zc:__cplusplus ??

@arvidn
Copy link
Owner Author

arvidn commented Jun 27, 2024

/Zc\:__cplusplus - shouldn't this be /Zc:__cplusplus ??

I believe : needs to be escaped in Jam strings

@arvidn arvidn merged commit ae20e11 into RC_2_0 Jun 30, 2024
38 of 43 checks passed
@arvidn arvidn deleted the msvc-cxx-version branch June 30, 2024 11:29
@arvidn arvidn mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvidn @xavier2k6