Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color theme revamp #7561

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Color theme revamp #7561

merged 3 commits into from
Jan 13, 2024

Conversation

sledgehammer999
Copy link
Contributor

@sledgehammer999 sledgehammer999 commented Nov 21, 2023

The current dark theme makes the online documentation a pain to read.
I took the liberty of implementing the color palette from the Nord Theme.
I am not sure that I got it right, but IMO it is more readable now than it was before. (I am a noob on the topic of colors)

I didn't touch the colors for the NOTE and WARNING alert boxes, because I don't have any idea on how the make them work correctly with Nord's color palette.

BEFORE
Screenshot 2023-11-21 at 02-26-02 libtorrent
AFTER
Screenshot 2023-11-21 at 02-24-58 libtorrent

@luzpaz
Copy link
Contributor

luzpaz commented Dec 13, 2023

A welcome change, thanks sledgehammer999!

@arvidn
Copy link
Owner

arvidn commented Dec 26, 2023

the new background color seems a bit bright for dark mode, doesn't it?
I take it it's primarily the contrast that's the current issue, yeah?

@sledgehammer999
Copy link
Contributor Author

the new background color seems a bit bright for dark mode, doesn't it?

It's probably a matter of one's preference. IMO, black is too dark for me as background.
It probably depends on the feel you get with the rest of the colors.

I would suggest this: Just browse the Nord theme website and switch to dark mode via the relevant UI element. Then you'll get a better feel for it.

I take it it's primarily the contrast that's the current issue, yeah?

If we disregard the background darkness(black or nord0), the contrast is exactly the issue for me.

@sledgehammer999
Copy link
Contributor Author

sledgehammer999 commented Jan 1, 2024

For completeness sake there are a few other popular color themes for dark modes out there:

  1. Dracula
  2. Gruvbox
  3. Solarized dark
  4. Molokai

--nord14: #a3be8c;
--nord15: #b48ead;
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose in an ideal world, just these color names would be set depending on dark-mode or light-mode. Everything else could then just refer to names instead of concrete colors

@arvidn arvidn merged commit 76dd5b4 into arvidn:RC_2_0 Jan 13, 2024
42 checks passed
@sledgehammer999
Copy link
Contributor Author

Woah, you've merged it! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants