fix and suppress some new clang warnings util addressed (in master)

.github/workflows/linux.yml

@@ -181,7 +181,7 @@ jobs:
       - name: install boost
         run: |
           sudo apt install libboost-tools-dev libboost-dev
-          echo "using clang_tidy : : clang-tidy \"-checks=-clang-analyzer-core.*,-clang-analyzer-unix.*\" : <cxxflags>-std=c++14 <cxxflags>-I/usr/local/clang-7.0.0/include/c++/v1 <cxxflags>-stdlib=libc++ <linkflags>-stdlib=libc++ ;" >> ~/user-config.jam;
+          echo "using clang_tidy : : clang-tidy \"-checks=-clang-analyzer-core.*,-clang-analyzer-unix.*\" : <cxxflags>-std=c++14 <cxxflags>-I/usr/local/clang-7.0.0/include/c++/v1 <cxxflags>-stdlib=libc++ <cxxflags>-Wno-unknown-warning-option <linkflags>-stdlib=libc++ ;" >> ~/user-config.jam;
 
       - name: analyze
         run: |

CMakeLists.txt

@@ -500,6 +500,7 @@ if(CMAKE_CXX_COMPILER_ID MATCHES Clang)
 		-Wno-exit-time-destructors
 		-Wno-weak-vtables
 		-Wno-return-std-move-in-c++11
+		-Wno-unsafe-buffer-usage
 		-Wno-unknown-warning-option
 	)
 elseif(CMAKE_CXX_COMPILER_ID MATCHES GNU)

Jamfile

@@ -270,6 +270,10 @@ rule warnings ( properties * )
 
 # libtorrent uses alloca() carefully
 		result += <cxxflags>-Wno-alloca ;
+
+# these warnings should all be addressed. Either by transitioning to span and
+# array, or by suppressing the warning for specific code
+		result += <cxxflags>-Wno-unsafe-buffer-usage ;
 	}
 
 	if <toolset>gcc in $(properties)

include/libtorrent/flags.hpp

@@ -46,7 +46,7 @@ struct bit_t
 	int m_bit_idx;
 };
 
-constexpr bit_t operator "" _bit(unsigned long long int b) { return bit_t{static_cast<int>(b)}; }
+constexpr bit_t operator ""_bit(unsigned long long int b) { return bit_t{static_cast<int>(b)}; }
 
 namespace flags {
 

src/ip_notifier.cpp

@@ -124,8 +124,8 @@ struct ip_change_notifier_impl final : ip_change_notifier
 
 	void async_wait(std::function<void(error_code const&)> cb) override
 	{
-		post(m_ios, [cb]()
-		{ cb(make_error_code(boost::system::errc::not_supported)); });
+		post(m_ios, [cb1=std::move(cb)]()
+		{ cb1(make_error_code(boost::system::errc::not_supported)); });
 	}
 
 	void cancel() override {}
@@ -153,10 +153,10 @@ struct ip_change_notifier_impl final : ip_change_notifier
 	void async_wait(std::function<void(error_code const&)> cb) override
 	{
 		m_socket.async_receive(boost::asio::buffer(m_buf)
-			, [cb=std::move(cb), this] (error_code const& ec, std::size_t const bytes_transferred)
+			, [cb1=std::move(cb), this] (error_code const& ec, std::size_t const bytes_transferred)
 			{
-				if (ec) cb(ec);
-				else this->on_notify(int(bytes_transferred), std::move(cb));
+				if (ec) cb1(ec);
+				else this->on_notify(int(bytes_transferred), std::move(cb1));
 			});
 	}
 
@@ -216,10 +216,10 @@ struct ip_change_notifier_impl final : ip_change_notifier
 		if (!pertinent)
 		{
 			m_socket.async_receive(boost::asio::buffer(m_buf)
-				, [cb=std::move(cb), this] (error_code const& ec, std::size_t const bytes_transferred)
+				, [cb1=std::move(cb), this] (error_code const& ec, std::size_t const bytes_transferred)
 				{
-					if (ec) cb(ec);
-					else this->on_notify(int(bytes_transferred), std::move(cb));
+					if (ec) cb1(ec);
+					else this->on_notify(int(bytes_transferred), std::move(cb1));
 				});
 		}
 		else

src/ssl.cpp

@@ -100,6 +100,8 @@ void set_server_name_callback(context_handle_type c, server_name_callback_type c
 #if defined __clang__
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wold-style-cast"
+#pragma clang diagnostic ignored "-Wcast-function-type-strict"
+#pragma clang diagnostic ignored "-Wunknown-warning-option"
 #endif
 	SSL_CTX_set_tlsext_servername_callback(c, cb);
 	SSL_CTX_set_tlsext_servername_arg(c, arg);

src/torrent.cpp

@@ -2440,9 +2440,9 @@ bool is_downloading_state(int const st)
 
 			span<sha256_hash> v2_span(hashes);
 			m_ses.disk_thread().async_hash(m_storage, m_checking_piece, v2_span, flags
-				, [self = shared_from_this(), hashes = std::move(hashes)]
+				, [self = shared_from_this(), hashes1 = std::move(hashes)]
 				(piece_index_t p, sha1_hash const& h, storage_error const& error) mutable
-				{ self->on_piece_hashed(std::move(hashes), p, h, error); });
+				{ self->on_piece_hashed(std::move(hashes1), p, h, error); });
 			++m_checking_piece;
 			if (m_checking_piece >= m_torrent_file->end_piece()) break;
 		}
@@ -10366,7 +10366,6 @@ namespace {
 		int num_peers = 0;
 		int num_downloaders = 0;
 		int missing_pieces = 0;
-		int num_interested = 0;
 		for (auto const p : m_connections)
 		{
 			TORRENT_INCREMENT(m_iterating_connections);
@@ -10382,8 +10381,6 @@ namespace {
 			if (p->share_mode()) continue;
 			if (p->upload_only()) continue;
 
-			if (p->is_peer_interested()) ++num_interested;
-
 			++num_downloaders;
 			missing_pieces += pieces_in_torrent - p->num_have_pieces();
 		}
@@ -11335,9 +11332,9 @@ namespace {
 
 		span<sha256_hash> v2_span(hashes);
 		m_ses.disk_thread().async_hash(m_storage, piece, v2_span, flags
-			, [self = shared_from_this(), hashes = std::move(hashes)]
+			, [self = shared_from_this(), hashes1 = std::move(hashes)]
 			(piece_index_t p, sha1_hash const& h, storage_error const& error) mutable
-			{ self->on_piece_verified(std::move(hashes), p, h, error); });
+			{ self->on_piece_verified(std::move(hashes1), p, h, error); });
 		m_picker->started_hash_job(piece);
 		m_ses.deferred_submit_jobs();
 	}

test/test_http_connection.cpp

@@ -240,7 +240,7 @@ TORRENT_TEST(socks5_pw_proxy_ssl) { run_suite("https", settings_pack::socks5_pw)
 #endif // USE_SSL
 
 TORRENT_TEST(http_proxy) { run_suite("http", settings_pack::http); }
-TORRENT_TEST(http__pwproxy) { run_suite("http", settings_pack::http_pw); }
+TORRENT_TEST(http_pwproxy) { run_suite("http", settings_pack::http_pw); }
 TORRENT_TEST(socks5_proxy) { run_suite("http", settings_pack::socks5); }
 TORRENT_TEST(socks5_pw_proxy) { run_suite("http", settings_pack::socks5_pw); }