Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ECDF code #2311

Merged
merged 36 commits into from
Feb 21, 2024
Merged

Refactor ECDF code #2311

merged 36 commits into from
Feb 21, 2024

Commits on Feb 2, 2024

  1. Remove redundant call to compute_ecdf

    @sethaxen
    sethaxen committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    a83e950 View commit details
    Browse the repository at this point in the history

  2. Sort samples in-place

    @sethaxen
    sethaxen committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    d74d0f3 View commit details
    Browse the repository at this point in the history

  3. Remove dead definition

    @sethaxen
    sethaxen committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    622238a View commit details
    Browse the repository at this point in the history

  4. Remove dead variable npoints

    @sethaxen
    sethaxen committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    908162e View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Use more descriptive variable names

    @sethaxen
    sethaxen committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    661676c View commit details
    Browse the repository at this point in the history

  2. Restructure to reduce code redundancy

    @sethaxen
    sethaxen committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    fd82d56 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Use consistent argument order

    @sethaxen
    sethaxen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    3612cdc View commit details
    Browse the repository at this point in the history

  2. Standardize more variable names

    @sethaxen
    sethaxen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    3348864 View commit details
    Browse the repository at this point in the history

  3. Split adjust_gamma into several functions

    @sethaxen
    sethaxen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c774f37 View commit details
    Browse the repository at this point in the history

  4. Define in terms of pointwise prob instead of gamma

    @sethaxen
    sethaxen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c9a9003 View commit details
    Browse the repository at this point in the history

  5. Refactor to use more informative function names

    @sethaxen
    sethaxen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    ce696dd View commit details
    Browse the repository at this point in the history

  6. Use ndraws for consistency

    @sethaxen
    sethaxen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e14bc08 View commit details
    Browse the repository at this point in the history

  7. Add utility function to simulate an ECDF

    @sethaxen
    sethaxen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5727fc1 View commit details
    Browse the repository at this point in the history

  8. Add type annotations

    @sethaxen
    sethaxen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e3bc1ab View commit details
    Browse the repository at this point in the history

  9. Rearrange code

    @sethaxen
    sethaxen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    0011182 View commit details
    Browse the repository at this point in the history

  10. Require CDF take vector inputs

    @sethaxen
    sethaxen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    780d395 View commit details
    Browse the repository at this point in the history

  11. Add notes for the future

    @sethaxen
    sethaxen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4e45374 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Define ecdf_confidence_band

    @sethaxen
    sethaxen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    d8a57a3 View commit details
    Browse the repository at this point in the history

  2. Remove rvs option

    @sethaxen
    sethaxen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    57c2355 View commit details
    Browse the repository at this point in the history

  3. Move ecdf utility functions to stats module

    @sethaxen
    sethaxen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    c4131b7 View commit details
    Browse the repository at this point in the history

  4. Make some functions internal

    @sethaxen
    sethaxen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    573306c View commit details
    Browse the repository at this point in the history

  5. Use binom.interval

    @sethaxen
    sethaxen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    03c92e7 View commit details
    Browse the repository at this point in the history

  6. Forward prob keeyword

    @sethaxen
    sethaxen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    7c3efe1 View commit details
    Browse the repository at this point in the history

  7. Mark function as private

    @sethaxen
    sethaxen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    52b6c24 View commit details
    Browse the repository at this point in the history

  8. Test ecdf helper functions

    @sethaxen
    sethaxen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    1882359 View commit details
    Browse the repository at this point in the history

  9. Revert "Require CDF take vector inputs" 

    This reverts commit 780d395.
    @sethaxen
    sethaxen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    bc7cea0 View commit details
    Browse the repository at this point in the history

  10. Map cdf over array

    @sethaxen
    sethaxen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    ab5b65b View commit details
    Browse the repository at this point in the history

  11. Fix formatting issues

    @sethaxen
    sethaxen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    1016956 View commit details
    Browse the repository at this point in the history

  12. Add changelog entry

    @sethaxen
    sethaxen committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    5c02322 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Oriol Abril-Pla <[email protected]>
    @sethaxen @OriolAbril
    sethaxen and OriolAbril authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3f21481 View commit details
    Browse the repository at this point in the history

  2. Use Any as type for random_state

    @sethaxen
    sethaxen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    1f13657 View commit details
    Browse the repository at this point in the history

  3. Update documentation of rvs and random_state

    @sethaxen
    sethaxen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    80327d5 View commit details
    Browse the repository at this point in the history

  4. Use default_rng in tests

    @sethaxen
    sethaxen committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    a77942b View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Document requirements of cdf function

    @sethaxen
    sethaxen committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    6cbcfe7 View commit details
    Browse the repository at this point in the history

  2. Assume cdf accepts array inputs

    @sethaxen
    sethaxen committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    e01f5c9 View commit details
    Browse the repository at this point in the history

  3. try making CI happy

    @OriolAbril
    OriolAbril authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    090af26 View commit details
    Browse the repository at this point in the history