Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general maintenance #2315

Merged
merged 7 commits into from
Feb 22, 2024
Merged

general maintenance #2315

merged 7 commits into from
Feb 22, 2024

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Feb 21, 2024

Description

General maintenance of the library. Fix several deprecations and warnings due to new releases
of pandas and xarray, prepare for numpy 2.0 and some compatibility changes for bokeh >3.0.

There are still many changes left to do with bokeh >3.0 but it isn't yet usable for us,
most plots don't work due to bugs such as bokeh/bokeh#13378
(fixed in current pre-release only) or bokeh/bokeh#13436 (no fix yet).
Thus I have pinned bokeh so our docs work and generate all the plots of the example gallery
which is currently not happening.

Last but not least, numba already supports 3.12, so I am moving the python versions in CI up:
3.10-3.12

Checklist

  • Follows official PR format
  • Includes a sample plot to visually illustrate the changes (only for plot-related functions)
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

📚 Documentation preview 📚: https://arviz--2315.org.readthedocs.build/en/2315/

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0a91faf) 86.72% compared to head (6564adc) 86.79%.
Report is 2 commits behind head on main.

Files Patch % Lines
arviz/plots/backends/bokeh/compareplot.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2315      +/-   ##
==========================================
+ Coverage   86.72%   86.79%   +0.06%     
==========================================
  Files         122      123       +1     
  Lines       12709    12728      +19     
==========================================
+ Hits        11022    11047      +25     
+ Misses       1687     1681       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahartikainen
Copy link
Contributor

We could pin asv to 0.6.1 until a new version is added to pypi.

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OriolAbril OriolAbril merged commit 2631d13 into arviz-devs:main Feb 22, 2024
11 checks passed
@OriolAbril OriolAbril deleted the maint branch February 22, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants